Mark: On Tue, Apr 26, 2011 at 11:15 AM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > No. As I said in the text you've quoted above you can also specify the > device mapping using the dev_name() of the device. Aah! I see it now--- the regulator_consumer_supply structure will take either the consumer's struct device pointer, or the device name of the consumer's struct device. The device name can easily be predicted (controlled, in fact) before the consumer itself is registered; in the case of i2c devices, it's the bus-id, i.e. "0-0038". Now it all fits together for me. Thanks for your patience! > It means you get reams of code in drivers conditionally using the > regulator API, all of which adds needless complexity all over the tree > as people invariably make everything conditional on the regulator not > being there when they shouldn't. This then means you also end up with > no meaningful error handling, all errors just get silently eaten. Now I think I see your point: better to have drivers check the result of regulator_get() themselves, rather than test a pointer coming in with the platform data. And since regulators are often registered as platform devices themselves, there is no way to get a valid result from regulator_get() in early-init board code anyway. b.g. -- Bill Gatliff bgat@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
