Re: [RFC][PATCH] KBUS messaging subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Jan 2011 20:20:42 +0100
Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:

> [Edited cc: list as my smtp server refused to send the original reply]

Apologies - I had copied down Grant Likely's email address wrong at ELCE.

> > Should I just submit the patch to this list?
> 
> You will get more feedback on lkml...

Indeed. I hoped to start small.

> - use __u32 (and friends) in exported headers - not uint32_t.

OK. I'd missed that. Presumably I should also be using u32 and friends
inside the kernel module itself, instead of uint32_t...

> - do not invent our own logging system. Use one of the standard
> methods.

I vaguely remember having a reason for that. Doubtless it was a bad
one. I shall attend to it.

> If you post for review try to divide it up a little.
> Maybe kbus.c in one patch, Makefile + Kconfig in last patch.
> It is a large file to review already.

That's useful guidance. I shall amend the code as suggested above and
resubmit as smaller, inline patches.

Tibs
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Gstreamer Embedded]     [Linux MMC Devel]     [U-Boot V2]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux ARM Kernel]     [Linux OMAP]     [Linux SCSI]

  Powered by Linux