On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote: > There are many uses of printk_once(KERN_<level>. > Add pr_<level>_once macros to avoid printk_once(KERN_<level> pr_fmt(fmt). > Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline void > functions for the #else cases to reduce embedded code size. > Neaten and organize the rest of the code. Looks fine to me. I'd missed the introduction of the pr_<level> macros and I'm not sure if I like the idea, but this is a tidy and well-presented cleanup and extension. Acked-by: Matt Mackall <mpm@xxxxxxxxxxx> -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html