On Thu, 2009-11-12 at 23:09 +0100, ext David VomLehn wrote: > On Thu, Nov 12, 2009 at 02:50:41PM -0500, Paul Gortmaker wrote: > > David VomLehn wrote: > >> Allows annotation of panics to include platform information. It's no big > >> deal to collect information, but way helpful when you are collecting > >> failure reports from a eventual base of millions of systems deployed in > >> other people's homes. > ... > > Why hook into panic() directly like this, vs. using the panic > > notifier list? If you use that, and then put the data handling > > magic that you need into your own kernel module that knows how > > to interface with the reporting apps that you have, you can > > do the whole thing without having to alter existing code, I think. > > I agree--a panic notifier list is probably a better approach. > That's what we currently use: http://marc.info/?l=linux-kernel&m=125655380512117&w=2 Very simple and does the job. Requires to rearrange the panic code a bit, though. Namely, to move notifiers invocation before the call to kmsg_dump(). Dumpers were introduced by Simon Kagstrom here: http://marc.info/?l=linux-kernel&m=125569530109871&w=2 Regards, Atal > David VL > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
