On Tue, Sep 01, 2009 at 07:32:25PM -0400, H Hartley Sweeten wrote:
> On Tuesday, September 01, 2009 4:24 PM, Tim Bird wrote:
> > Some places in the kernel break the message into pieces, like so:
> >
> > printk(KERN_ERR, "Error: first part ");
> > ...
> > printk(" more info for error.\n");
>
> Technically, shouldn't the second part of the message actually be:
>
> printk(KERN_CONT " more info for error.\n");
>
> Maybe some mechanism could be created to handle the continued message
> if they have the KERN_CONT?
Yes it's true that KERN_CONT isn't handled correctly, but I don't see a way
to change that.
> > These parts would not be handled consistently under certain
> > conditions.
> >
> > It would be confusing to see only part of the message,
> > but I don't know how often this construct is used.
$ grep -R KERN_CONT linux-2.6 | wc -l
373
> > Maybe
> > another mechanism is needed to ensure that continuation
> > printk lines have the same log level as their start strings.
I currently don't see a way to achieve this with the CPP.
> > But, overall, very slick! It's nice to see a solution that doesn't
> > require changing all printks statements in the kernel.
Yes that's what I thought too. Thanks to the comments so far the next
version of the patch will contain even less changes to the rest of the
kernel.
> I haven't looked over this patch series yet but does it work with the
> pr_<level> macros (pr_info, pr_err, etc.)?
It should work, yes.
Regards,
Marc
--
Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
