On 11/25/08 10:55 AM, Josh Boyer wrote: > On Tue, 25 Nov 2008 12:53:12 -0600 > "Matt Sealey" <matt@xxxxxxxxxxxxxx> wrote: >> Nitpick, really.. shouldn't the logbuffer location(s) be some device tree >> property(ies), perhaps something in the >> /chosen node that U-Boot etc. can then fill out? > > I don't think that's a nitpick. It's a fundamental change in how this > would all work. However, I do think you're generally right. > > Perhaps not /chosen, but maybe something like /rtas or /firmware, etc. I'm inclined to agree with you both; however, the submitted implementation was a choice of expediency given the existing DENX implementation and a customer that needed the feature "yesterday". ARM, MIPS, et al have not yet adopted device trees, correct? If so, is there value in providing the submitted implementation and adding support for getting said information from the device tree as another option if such information exists? Regards, Grant -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
