On Wed, Oct 29, 2008 at 2:44 AM, Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx> wrote: > Grant Likely wrote: >> On Tue, Oct 28, 2008 at 5:31 AM, Paulius Zaleckas >> <paulius.zaleckas@xxxxxxxxxxxx> wrote: >>> Mike Frysinger wrote: >>>> On Tue, Oct 28, 2008 at 06:35, Paulius Zaleckas wrote: >>>>> +config MDIO_GPIO >>>>> + tristate "Support for GPIO bitbanged MDIO buses" >>>>> config MDIO_OF_GPIO >>>>> tristate "Support for GPIO lib-based bitbanged MDIO buses" >>>> seems to me these drivers have the same description ... >>> Yes... but it is MDIO_OF_GPIO description that needs changing... >>> Should I make patch for it? >> >> Wait a minute.... This is the same driver and it's just been >> duplicated. NAK. Please don't do this. Instead add a platform bus >> binding to the existing driver. Most of the code can be shared. > > It is very similar. If highly #ifdef'ed driver is OK then I can merge > these driver to single one, but mdio-ofgpio driver name will have to > change to mdio-gpio. OK? Absolutely, change the name. Also, I don't think you'll need as many #ifdefs as you fear you do. :-) Mostly you'll need two #ifdef sections; one for the of_platform binding and one for the platform binding. drivers/video/xilinxfb.c is a good example of how to do it. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
