On Tue, Oct 28, 2008 at 04:30, Paulius Zaleckas wrote: > Mike Frysinger wrote: >> On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote: >>> + if (gpio_request(bitbang->mdc, "mdc")) >>> + goto out_free_bitbang; >>> + >>> + if (gpio_request(bitbang->mdio, "mdio")) >>> + goto out_free_mdc; >> >> maybe include driver name and/or the platform id ? if you have >> multiple mdio-gpio's running at the same time, coordinating may get a >> little messy ... > > Well... this is mostly for debugging only... I don't like the idea > to add additional char[..] variable and use sprintf... > IMO this would be just a bloat... if realistically you'd only run one instance of this driver on a platform, then it'll probably be fine >>> + new_bus->name = "GPIO Bitbanged MII", >> >> platform id here too ? > > If you take a look one line below you would see that bus ID is formed > using platform id. Does this really need to be duplicated also in the > name? i guess if you can divine the differences from a populated /sys directory, it should be ok as well -mike -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
