On Tue, Oct 28, 2008 at 03:37, Paulius Zaleckas wrote: > Mike Frysinger wrote: >> On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote: >>> + new_bus->irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL); >> >> oh, and this should be kcalloc() > > Why? kcalloc() fills allocated memory with zeros and in this case it has > to be filled with -1... this is done by further for() routine. I don't > see the point to fill it with zeros before... i thought it was a call to kzalloc(). kcalloc() is better for arrays, but if you dont need the memory zero-ed first, it's a hard sell of proper style vs wasted performance. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
