On Thu, 21 Aug 2008, Jared Hulbert wrote: > > Use DEFINE_MUTEX and drop the mutex_init() down in the init function. > > okay. by drop you mean delete? Yes. > > axfs_uncompress_init() and axfs_uncompress_exit() are only called during > > init and exit of the module, no need for the initialized variable and the > > functions can be annotated with __init and __exit. > > can be annotated or should be? Should be. We only need them once during init and cleanup. If you want to call axfs_uncompress_exit() from init_axfs_fs() to clean up in case of register_filesystem failing, you can't annotate axfs_uncompress_exit() with __exit. Sven -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
