On Thursday 21 August 2008, Jared Hulbert wrote: > +/***************** functions in other axfs files ******************************/ > +int axfs_get_sb(struct file_system_type *, int, const char *, void *, > + struct vfsmount *); > +void axfs_kill_super(struct super_block *); > +void axfs_profiling_add(struct axfs_super *, unsigned long, unsigned int); > +int axfs_copy_mtd(struct super_block *, void *, u64, u64); > +int axfs_copy_block(struct super_block *, void *, u64, u64); *Never* put extern declarations into a .c file, that's what headers are for. If you ever change the definition, the compiler doesn't get a chance to warn you otherwise. > +/******************************************************************************/ > +static int axfs_readdir(struct file *, void *, filldir_t); > +static int axfs_mmap(struct file *, struct vm_area_struct *); > +static ssize_t axfs_file_read(struct file *, char __user *, size_t, loff_t *); > +static int axfs_readpage(struct file *, struct page *); > +static int axfs_fault(struct vm_area_struct *, struct vm_fault *); > +static struct dentry *axfs_lookup(struct inode *, struct dentry *, > + struct nameidata *); > +static int axfs_get_xip_mem(struct address_space *, pgoff_t, int, void **, > + unsigned long *); For style reasons, also please don't put static forward declarations anywhere, but define the functions in the right order so you don't need them. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
