On Wed, Mar 19, 2025 at 07:24:53AM -0700, Greg Kroah-Hartman wrote: > On Wed, Mar 19, 2025 at 01:15:38PM +0000, Sudeep Holla wrote: > > On Tue, Mar 18, 2025 at 06:10:41PM +0100, Ard Biesheuvel wrote: > > > On Tue, 18 Mar 2025 at 18:02, Sudeep Holla <sudeep.holla@xxxxxxx> wrote: > > > > > > > > The EFI secret area driver does not require the creation of a platform > > > > device. Originally, this approach was chosen for simplicity when the > > > > driver was first implemented. > > > > > > > > With the introduction of the lightweight faux device interface, we now > > > > have a more appropriate alternative. Migrate the driver to utilize the > > > > faux bus, given that the platform device it previously created was not > > > > a real one anyway. This will simplify the code, reducing its footprint > > > > while maintaining functionality. > > > > > > > > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx> > > > > Cc: linux-efi@xxxxxxxxxxxxxxx > > > > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx> > > > > > > So how is module autoload supposed to work with this driver? > > > > > > > IIUC, you are right. It doesn't work. I got carried away how efi_pstore was > > autoloaded in Ubuntu even without alias or platform/faux device creation. I > > don't know how yet but that works. This modules doesn't. > > > > So we may have to retain platform device/driver for autoloading reasons ? > > If that's required, yes. Thanks for confirming. I will drop this and see if autoloading is needed in any other modules as well. -- Regards, Sudeep
