Re: fs/efivarfs/vars.c:375: warning: Function parameter or struct member 'duplicate_check' not described in 'efivar_init'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-01-10 at 05:02 +0800, kernel test robot wrote:
> tree:  
> https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> head:   5e948d5cefebebe2315faf356d7b5180144b17b0
> commit: 43039cdd1a14ed12c7b506a2d78c7fa708444b06 efivarfs: add
> variable resync after hibernation
> date:   11 hours ago
> config: x86_64-buildonly-randconfig-002-20250109
> (https://download.01.org/0day-ci/archive/20250110/202501100429.RSwlJM
> m0-lkp@xxxxxxxxx/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20250110/202501100429.RSwlJM
> m0-lkp@xxxxxxxxx/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new
> version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202501100429.RSwlJMm0-lkp@xxxxxxxxx/
> 
> All warnings (new ones prefixed by >>):
> 
> > > fs/efivarfs/vars.c:375: warning: Function parameter or struct
> > > member 'duplicate_check' not described in 'efivar_init'

Sorry, my fault.  If you fold this one-liner into "efivarfs: add
variable resync after hibernation" it will correct the warning.

James

---

diff --git a/fs/efivarfs/vars.c b/fs/efivarfs/vars.c
index d720d780648b..6edc10958ecf 100644
--- a/fs/efivarfs/vars.c
+++ b/fs/efivarfs/vars.c
@@ -364,6 +364,7 @@ static void dup_variable_bug(efi_char16_t *str16, efi_guid_t *vendor_guid,
  * efivar_init - build the initial list of EFI variables
  * @func: callback function to invoke for every variable
  * @data: function-specific data to pass to @func
+ * @duplicate_check: fail if a duplicate variable is found
  *
  * Get every EFI variable from the firmware and invoke @func. @func
  * should populate the initial dentry and inode tree.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux