On Mon, 6 Jan 2025 at 20:03, Breno Leitao <leitao@xxxxxxxxxx> wrote:
>
> Tag firmware-related error messages with FW_BUG in efi_memattr_init() to
> make EFI firmware issues more discoverable and consistent with kernel
> error reporting conventions.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> drivers/firmware/efi/memattr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/memattr.c b/drivers/firmware/efi/memattr.c
> index e727cc5909cb676c47d787ab0d7754b6fdcb493d..5f83cdea88b05cb325e9f90c14a0048131e53cfa 100644
> --- a/drivers/firmware/efi/memattr.c
> +++ b/drivers/firmware/efi/memattr.c
> @@ -29,13 +29,13 @@ void __init efi_memattr_init(void)
>
> tbl = early_memremap(efi_mem_attr_table, sizeof(*tbl));
> if (!tbl) {
> - pr_err("Failed to map EFI Memory Attributes table @ 0x%lx\n",
> + pr_err(FW_BUG "Failed to map EFI Memory Attributes table @ 0x%lx\n",
> efi_mem_attr_table);
> return;
> }
>
> if (tbl->version > 2) {
> - pr_warn("Unexpected EFI Memory Attributes table version %d\n",
> + pr_warn(FW_BUG "Unexpected EFI Memory Attributes table version %d\n",
> tbl->version);
> goto unmap;
> }
>
Neither of these are firmware bugs, so we shouldn't report them as such.
(A future version of the table could be > 2, and we wouldn't know how
to deal with that. That doesn't mean there is anything wrong with the
firmware, it only means the kernel is too old)
