On 10/2/2024 4:04 PM, Dan Williams wrote:
Smita Koralahalli wrote:
Refactor computation of cxlds to a common function get_cxl_devstate().
The above function could then be reused in both FW-First Component and
Protocol error reporting and handling.
Ira caught the bug in the cleanup conversion, but I am otherwise not
convinced there would be much reuse for a helper like this given any
endpoint-flagged protocol errors would reuse the common
cxl_handle_cper_event(), unless I am missing something?
Yeah, the only intent was to not redo the BDF decoding at two places. I
don't see a problem in calling cxl_handle_prot_err() inside
cxl_handle_cper_event() as Ira suggested in 4/4.
However, I think all of this would fall off if we isolate protocol
errors from cxl_cper_fifo and handle them separately.
Thanks
Smita
