RE: [Patch] Do not clear BSS region in x86 stub

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ard Biesheuvel <ardb@xxxxxxxxxx>
Subject: RE: [Patch] Do not clear BSS region in x86 stub
From: "Shao, Marshall" <Marshall.Shao@xxxxxxxx>
Date: Wed, 24 Jul 2024 01:48:52 +0000
Accept-language: en-US
Cc: "linux-efi@xxxxxxxxxxxxxxx" <linux-efi@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "Mishra, Ashish" <Ashish.Mishra4@xxxxxxxx>, "Chia, Jia Yuan" <JiaYuan.Chia@xxxxxxxx>, "Dion, Christopher" <Christopher.Dion@xxxxxxxx>, "Caisse, Joe" <Joe.Caisse@xxxxxxxx>, "Mukundan, Govind" <Govind.Mukundan@xxxxxxxx>
In-reply-to: <CAMj1kXEQXZc2Vpgh5JA3nCCw=LB0kjLgQoximQ4pZhcJ91iOnw@mail.gmail.com>
Msip_labels: MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_ActionId=75adc379-3fff-4811-9d73-9913a0bf1794;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_ContentBits=0;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_Enabled=true;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_Method=Privileged;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_Name=Public No Visual Label;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_SetDate=2024-07-24T01:01:48Z;MSIP_Label_dad3be33-4108-4738-9e07-d8656a181486_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd;
References: <DS7PR19MB570996A580C6F5D2C9CACCE48BA32@DS7PR19MB5709.namprd19.prod.outlook.com> <DS7PR19MB5709B2A263E769B461091B0D8BA32@DS7PR19MB5709.namprd19.prod.outlook.com> <CAMj1kXHBSNxrzbQoaDea7HFcjN9HHk5==tXg1WLHDzW61aj4cg@mail.gmail.com> <DS7PR19MB5709B39C90153DAA27DA122D8BAE2@DS7PR19MB5709.namprd19.prod.outlook.com> <CAMj1kXHS0rr9DfKCeD-Zz7y1Bk-3ncn2cEgVmnWE0Jq1B=+Acg@mail.gmail.com> <DS7PR19MB570924EC5BB1BA3F321A65B98BA82@DS7PR19MB5709.namprd19.prod.outlook.com> <CAMj1kXFjWBpOij5V3=-9etqTW9p8guqPDCGU3DK0Yxq6zrBiBQ@mail.gmail.com> <DS7PR19MB57092B4012BEFBBA52E2C2748BA92@DS7PR19MB5709.namprd19.prod.outlook.com> <CAMj1kXEQXZc2Vpgh5JA3nCCw=LB0kjLgQoximQ4pZhcJ91iOnw@mail.gmail.com>
Thread-index: AdrYGyaFCseU4QE3SCibBf0Ev6R9+wAQOiGAAABrtYAAlzZgQAAtv+GAAC61pjAAFgXwgAAb9bQQAAX92YAAFi3EMA==
Thread-topic: [Patch] Do not clear BSS region in x86 stub

> Can you explain why this is the case? systemd-stub should only use the
> EFI handover protocol for v5.8 or older.

Are you referring to this comment? In systemd/src/boot/efi/linux.c

> This method works for Linux 5.8 and newer on ARM/Aarch64, x86/x68_64 
> and RISC-V.

I noticed that this was not present in systemd v249, that could be the reason. 
Upgrading the systemd version may solve the issue. I will give it a try.

Anyway, thanks for bringing the issue to systemd's attention.

References:
- [Patch] Do not clear BSS region in x86 stub
  - From: Shao, Marshall
- [Patch] Do not clear BSS region in x86 stub
  - From: Shao, Marshall
- Re: [Patch] Do not clear BSS region in x86 stub
  - From: Ard Biesheuvel
- RE: [Patch] Do not clear BSS region in x86 stub
  - From: Shao, Marshall
- Re: [Patch] Do not clear BSS region in x86 stub
  - From: Ard Biesheuvel
- RE: [Patch] Do not clear BSS region in x86 stub
  - From: Shao, Marshall
- Re: [Patch] Do not clear BSS region in x86 stub
  - From: Ard Biesheuvel
- RE: [Patch] Do not clear BSS region in x86 stub
  - From: Shao, Marshall
- Re: [Patch] Do not clear BSS region in x86 stub
  - From: Ard Biesheuvel

Prev by Date: Re: [PATCH v3 0/2] efi/x86: Call set_os() protocol on dual GPU Macs
Next by Date: Re: [PATCH v3 2/2] x86/mm/ident_map: Use gbpages only where full GB page should be mapped.
Previous by thread: Re: [Patch] Do not clear BSS region in x86 stub
Next by thread: Re: [Patch] Do not clear BSS region in x86 stub
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]