Hi Ard, Lukas Although the patch has been upstreamed, and works well for the Macs included, we have noticed another issue. For the Macs having a single GPU, in case a person uses an eGPU, they still need this apple-set-os quirk for hybrid graphics. This was not reported that time by anyone since people who use an eGPU are quite rare. I'm not sure how to handle this. Had a few ideas like: 1. Enable this for all T2 Macs. 2. Enable this for all Macs. 3. Add a kernel parameter. Would like your ideas and a possible fix for the same. Thanks Aditya > On 2 Jul 2024, at 1:12 AM, Aditya Garg <gargaditya08@xxxxxxxx> wrote: > > Tested-by: Aditya Garg <gargaditya08@xxxxxxxx> > > Thanks for the support Ard :) > >> On 1 Jul 2024, at 7:40 PM, Ard Biesheuvel <ardb+git@xxxxxxxxxx> wrote: >> >> From: Ard Biesheuvel <ardb@xxxxxxxxxx> >> >> v3: >> - add patch to make the SMBIOS protocol glue code compatible with mixed >> mode on x86 >> - update Aditya's patch to limit the effect to dual GPU Macs that are >> known to require the set_os() calls in order for both GPUs to remain >> active after boot >> - drop mixed mode handling of set_os() protocol, and dereference the >> struct members directly >> >> Cc: Aditya Garg <gargaditya08@xxxxxxxx> >> Cc: Hans de Goede <hdegoede@xxxxxxxxxx> >> Cc: Lukas Wunner <lukas@xxxxxxxxx> >> Cc: Kerem Karabay <kekrby@xxxxxxxxx> >> Cc: Orlando Chamberlain <orlandoch.dev@xxxxxxxxx> >> >> Aditya Garg (1): >> x86/efistub: Call Apple set_os protocol on dual GPU Intel Macs >> >> Ard Biesheuvel (1): >> efistub/x86: Enable SMBIOS protocol handling for x86 >> >> drivers/firmware/efi/libstub/Makefile | 2 +- >> drivers/firmware/efi/libstub/smbios.c | 42 ++++++++---- >> drivers/firmware/efi/libstub/x86-stub.c | 72 +++++++++++++++++++- >> include/linux/efi.h | 1 + >> 4 files changed, 98 insertions(+), 19 deletions(-) >> >> -- >> 2.45.2.803.g4e1b14247a-goog >>
