On 15.03.24 10:16, Ard Biesheuvel wrote:
Hi Tim, On Fri, 15 Mar 2024 at 01:27, Tim Schumacher <timschumi@xxxxxx> wrote:Work around a quirk in a few old (2011-ish) UEFI implementations, where a call to `GetNextVariableName` with a buffer size larger than 512 bytes will always return EFI_INVALID_PARAMETER. This was already done to efivarfs in f45812cc23fb ("efivarfs: Request at most 512 bytes for variable names"), but the second copy of the variable iteration implementation was overlooked. Signed-off-by: Tim Schumacher <timschumi@xxxxxx>Thanks for the patch. I'll take it as a fix. As an aside, you really want to avoid EFI pstore in general, and specifically on such old systems with quirky UEFI implementations.
I found this by chance while looking for appearances of the magic value of 1024, and decided to split it out because this would have been the only change that modifies behavior. I didn't intend to actually use it after fixing it up, although I did make sure that it now does more than it did previously. If we can save someone a confused "Why is this done differently here?" (and have a reason to boil down the code to a single implementation in the future), then that is probably good enough on its own.
