On Thu, Feb 22, 2024 at 5:32 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Feb 21, 2024 at 03:30:24PM -0800, Saravana Kannan wrote: > > Add support for this property so that dependency cycles can be broken and > > fw_devlink can do better probe/suspend/resume ordering between devices in a > > dependency cycle. > > ... > > > - fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), 0); > > + fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), > > + flags); > > I would leave it one line despite being 83 characters long. > > ... > > > - of_link_to_phandle(con_dev_np, phandle); > > + of_link_to_phandle(con_dev_np, phandle, > > + s->fwlink_flags); > > I would leave this on one line, it's only 81 characters. I don't have a strong opinion either way. If I need to send another revision out, I'll address this (if checkpatch doesn't complain). -Saravana
