Smita Koralahalli wrote:
> On 1/2/2024 8:23 AM, Ira Weiny wrote:
> > Smita Koralahalli wrote:
[snip]
> >> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> >> index 17eadee819b6..afa71ee0437c 100644
> >> --- a/include/linux/cxl-event.h
> >> +++ b/include/linux/cxl-event.h
> >> @@ -141,8 +141,12 @@ struct cxl_cper_event_rec {
> >> union cxl_event event;
> >> } __packed;
> >>
> >> +struct cxl_cper_rec_data {
> >> + struct cxl_cper_event_rec rec;
> >
> > NIT: I would call this something like event to distinguish it from other
> > record data.
>
> What do you think of the below?
>
> struct cxl_cper_event_info {
> struct cxl_cper_event_rec rec;
> struct cxl_cper_prot_err {
> struct cxl_ras_capability_regs cxl_ras;
> int severity;
> } p_err;
> };
>
> Addressed changing to sub-struct and copying the struct rather than
> pointer comments in patch 3..
That is much better. Thanks!
Ira
