Jonathan Cameron wrote: > On Fri, 15 Dec 2023 15:26:32 -0800 > Ira Weiny <ira.weiny@xxxxxxxxx> wrote: [snip] > > > > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx> > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > One trivial thing inline. > > + Agree that notifier naming is unwise given what that means elsewhere in the > kernel. Changing that. > > > diff --git a/drivers/firmware/efi/cper_cxl.h b/drivers/firmware/efi/cper_cxl.h > > index 86bfcf7909ec..71f27b3e2810 100644 > > --- a/drivers/firmware/efi/cper_cxl.h > > +++ b/drivers/firmware/efi/cper_cxl.h > > @@ -10,11 +10,38 @@ > > #ifndef LINUX_CPER_CXL_H > > #define LINUX_CPER_CXL_H > > > > +#include <linux/cxl-event.h> > > + > > /* CXL Protocol Error Section */ > > #define CPER_SEC_CXL_PROT_ERR \ > > GUID_INIT(0x80B9EFB4, 0x52B5, 0x4DE3, 0xA7, 0x77, 0x68, 0x78, \ > > 0x4B, 0x77, 0x10, 0x48) > > > > +/* CXL Event record UUIDs are formated at GUIDs and reported in section type */ > > as GUIDs > Fixed, thanks, Ira