Dan Williams wrote: > Ira Weiny wrote: > > Dan Williams wrote: > > > Ira Weiny wrote: > > > > Dan Williams wrote: > > > > > Ira Weiny wrote: > > > > > > > > > > > [snip] > > > > > > > > > #define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0) > > > > static void cxl_cper_event_call(struct cxl_cper_notifier_data *nd) > > > > > > Is struct cxl_cper_notifier_data needed anymore, just pass the record > > > reference? > > > > I think so because the type of record is ID'ed by the GUID which is not > > part of the common record. So the notifier data adds the cxl_event_type > > enum. > > Ah, yup, but then I wonder if CPER can just do the GUID to type enum > lookup and keep the CXL side GUID-free? I.e. just pass the type as a > separate argument. Just saw this after I sent V2. Yes the CXL side is GUID free, has been since an early RFC. But the data structure has the event in it. If you want I can change the callback signature but it seems reasonable to me as it is in V2. Sorry for not catching this before I sent it out, Ira
