Smita Koralahalli wrote: > On 11/1/2023 2:11 PM, Ira Weiny wrote: > > [snip] > > + > > +#define CPER_CXL_DEVICE_ID_VALID BIT(0) > > +#define CPER_CXL_DEVICE_SN_VALID BIT(1) > > +#define CPER_CXL_COMP_EVENT_LOG_VALID BIT(2) > > +struct cper_cxl_event_rec { > > + struct { > > + u32 length; > > + u64 validation_bits; > > + struct cper_cxl_event_devid { > > + u16 vendor_id; > > + u16 device_id; > > + u8 func_num; > > + u8 device_num; > > + u8 bus_num; > > + u16 segment_num; > > + u16 slot_num; /* bits 2:0 reserved */ > > + u8 reserved; > > + } device_id; > > + struct cper_cxl_event_sn { > > + u32 lower_dw; > > + u32 upper_dw; > > + } dev_serial_num; > > + } hdr; > > + > > + union cxl_event event; > > +}; > > Do we need pragma pack or similar for alignment here? Yes good catch. Fixed, Ira