On Tue, Jun 06, 2023 at 06:16:06PM +0200, Borislav Petkov wrote: > On Tue, Jun 06, 2023 at 05:26:28PM +0300, Kirill A. Shutemov wrote: > > v14: > > - Fix error handling in arch_accept_memory() (Tom); > > - Address Borislav's feedback: > > + code restructure; > > + added/adjusted comments; > > In file included from arch/x86/coco/tdx/tdx-shared.c:1: > ./arch/x86/include/asm/tdx.h: In function ‘tdx_kvm_hypercall’: > ./arch/x86/include/asm/tdx.h:70:17: error: ‘ENODEV’ undeclared (first use in this function) > 70 | return -ENODEV; > | ^~~~~~ > ./arch/x86/include/asm/tdx.h:70:17: note: each undeclared identifier is reported only once for each function it appears in > make[4]: *** [scripts/Makefile.build:252: arch/x86/coco/tdx/tdx-shared.o] Error 1 > make[3]: *** [scripts/Makefile.build:494: arch/x86/coco/tdx] Error 2 > make[2]: *** [scripts/Makefile.build:494: arch/x86/coco] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [scripts/Makefile.build:494: arch/x86] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:2026: .] Error 2 > > Not enough build tests ran? Hm. I've got a lot of reports from 0day, but never this one. Kai has posted patch that fixes it already: https://lore.kernel.org/all/20230606034000.380270-1-kai.huang@xxxxxxxxx/ > $ grep INTEL_TDX_GUEST .config > CONFIG_INTEL_TDX_GUEST=y > $ grep KVM_GUEST .config > $ > > Why does that tdx_kvm_hypercall() thing even depend on CONFIG_KVM_GUEST? Because nobody uses it otherwise. For instance, Hyper-V guest will no need this KVM glue. -- Kiryl Shutsemau / Kirill A. Shutemov
