On Mon, 22 May 2023 at 07:33, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > The Make variable containing the objcopy flags may be constructed from > the output of build tools operating on build artifacts, and these may > not exist when doing a make clean. > > So avoid evaluating them eagerly, to prevent spurious build warnings. > > Suggested-by: Pedro Falcato <pedro.falcato@xxxxxxxxx> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > --- > drivers/firmware/efi/libstub/Makefile.zboot | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/libstub/Makefile.zboot b/drivers/firmware/efi/libstub/Makefile.zboot > index 89ef820f3b34483a..2c489627a8078945 100644 > --- a/drivers/firmware/efi/libstub/Makefile.zboot > +++ b/drivers/firmware/efi/libstub/Makefile.zboot > @@ -32,7 +32,8 @@ zboot-size-len-$(CONFIG_KERNEL_GZIP) := 0 > $(obj)/vmlinuz: $(obj)/vmlinux.bin FORCE > $(call if_changed,$(zboot-method-y)) > > -OBJCOPYFLAGS_vmlinuz.o := -I binary -O $(EFI_ZBOOT_BFD_TARGET) $(EFI_ZBOOT_OBJCOPY_FLAGS) \ > +# avoid eager evaluation to prevent references to non-existent build artifacts > +OBJCOPYFLAGS_vmlinuz.o = -I binary -O $(EFI_ZBOOT_BFD_TARGET) $(EFI_ZBOOT_OBJCOPY_FLAGS) \ > --rename-section .data=.gzdata,load,alloc,readonly,contents > $(obj)/vmlinuz.o: $(obj)/vmlinuz FORCE > $(call if_changed,objcopy) > -- > 2.39.2 > Yes, that fixes the warning. So -- Tested-by: Alan Bartlett <ajb@xxxxxxxxxx> Than you. Alan.
