Please fix all your subjects as explained here: https://kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject On Mon, May 08, 2023 at 09:03:11AM +0200, Ard Biesheuvel wrote: > We don't actually use a global offset table (GOT) in the 32-bit Please use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood. Personal pronouns are ambiguous in text, especially with so many parties/companies/etc developing the kernel so let's avoid them please. > diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S > index 987ae727cf9f0d04..53cbee1e2a93efce 100644 > --- a/arch/x86/boot/compressed/head_32.S > +++ b/arch/x86/boot/compressed/head_32.S > @@ -58,7 +58,7 @@ SYM_FUNC_START(startup_32) > leal (BP_scratch+4)(%esi), %esp > call 1f > 1: popl %edx > - addl $_GLOBAL_OFFSET_TABLE_+(.-1b), %edx > + leal (_GLOBAL_OFFSET_TABLE_ - 1b)(%edx), %edx Yeah, that's a bit better. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
