Re: [PATCH] efi: earlycon: Reprobe after parsing config tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 13, 2023 at 6:12 AM Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
>
> Commit 732ea9db9d8a ("efi: libstub: Move screen_info handling to common
> code") reorganized the earlycon handling so that all architectures pass
> the screen_info data via a EFI config table instead of populating struct
> screen_info directly, as the latter is only possible when the EFI stub
> is baked into the kernel (and not into the decompressor).
>
> However, this means that struct screen_info may not have been populated
> yet by the time the earlycon probe takes place, and this results in a
> non-functional early console.
>
> So let's probe again right after parsing the config tables and
> populating struct screen_info. Note that this means that earlycon output
> starts a bit later than before, and so it may fail to capture issues
> that occur while doing the early EFI initialization.
>
> Cc: Xuefeng Li <lixuefeng@xxxxxxxxxxx>
> Cc: Xuerui Wang <kernel@xxxxxxxxxx>
> Cc: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> Reported-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Fixes: 732ea9db9d8a ("efi: libstub: Move screen_info handling to common code")
> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

Thanks for the fix!  On Snapdragon laptops:

Tested-by: Shawn Guo <shawn.guo@xxxxxxxxxx>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux