Hi Youling, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on efi/next] [also build test WARNING on linus/master v6.3-rc1 next-20230308] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Youling-Tang/efistub-LoongArch-Reimplement-kernel_entry_address/20230307-190013 base: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next patch link: https://lore.kernel.org/r/1678186653-27659-1-git-send-email-tangyouling%40loongson.cn patch subject: [PATCH] efistub: LoongArch: Reimplement kernel_entry_address() config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20230309/202303090430.e6BB0Txr-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1f509b49ceeeeb3c59483c685592f8d87b70f169 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Youling-Tang/efistub-LoongArch-Reimplement-kernel_entry_address/20230307-190013 git checkout 1f509b49ceeeeb3c59483c685592f8d87b70f169 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/firmware/efi/libstub/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303090430.e6BB0Txr-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/firmware/efi/libstub/loongarch.c: In function 'get_kernel_offset': drivers/firmware/efi/libstub/loongarch.c:46:45: error: 'PHYS_LINK_KADDR' undeclared (first use in this function) 46 | return EFI_KIMG_PREFERRED_ADDRESS - PHYS_LINK_KADDR; | ^~~~~~~~~~~~~~~ drivers/firmware/efi/libstub/loongarch.c:46:45: note: each undeclared identifier is reported only once for each function it appears in drivers/firmware/efi/libstub/loongarch.c: At top level: >> drivers/firmware/efi/libstub/loongarch.c:49:15: warning: no previous prototype for 'kernel_entry_address' [-Wmissing-prototypes] 49 | unsigned long kernel_entry_address(void) | ^~~~~~~~~~~~~~~~~~~~ drivers/firmware/efi/libstub/loongarch.c: In function 'get_kernel_offset': drivers/firmware/efi/libstub/loongarch.c:47:1: error: control reaches end of non-void function [-Werror=return-type] 47 | } | ^ cc1: some warnings being treated as errors vim +/kernel_entry_address +49 drivers/firmware/efi/libstub/loongarch.c 48 > 49 unsigned long kernel_entry_address(void) 50 { 51 return *(unsigned long *)(EFI_KIMG_PREFERRED_ADDRESS + 8) + 52 get_kernel_offset(); 53 } 54 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
