On Fri, 28 Oct 2022 at 14:21, Aditya Garg <gargaditya08@xxxxxxxx> wrote:
>
>
>
> Hi Ard
>
> This patch you sent fixed my issue!
>
Thanks for testing!
> > On 27-Oct-2022, at 7:27 PM, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote:
> >
> > Commit 8a254d90a775 ("efi: efivars: Fix variable writes without
> > query_variable_store()") addressed an issue that was introduced during
> > the EFI variable store refactor, where alternative implementations of
> > the efivars layer that lacked query_variable_store() would no longer
> > work.
> >
> > Unfortunately, there is another case to consider here, which was missed:
> > if the efivars layer is backed by the EFI runtime services as usual, but
> > the EFI implementation predates the introduction of QueryVariableInfo(),
> > we will return EFI_UNSUPPORTED, and this is no longer being dealt with
> > correctly.
> >
> > So let's fix this, and while at it, clean up the code a bit, by merging
> > the check_var_size() routines as well as their callers.
> >
>
> Thanks
> Aditya
