Re: [PATCH 02/21] arm64: efi: Avoid dcache_clean_poc() altogether in efi_enter_kernel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 18 Oct 2022 at 13:57, Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
>
> On Mon, Oct 17, 2022 at 07:16:41PM +0200, Ard Biesheuvel wrote:
> > To allow efi_enter_kernel() to be shared with the EFI zboot decompressor
> > build, drop another reference to dcache_clean_poc() and replace it with
> > a single DC CVAC instruction. To ensure that it covers the remainder of
> > efi_enter_kernel() as intended, reorganize the code a bit so it fits in
> > a 32-byte cacheline, and align it to 32 bytes. (Even though the
> > architecture defines 16 as the minimum D-cache line size, even the
> > chosen value of 32 is highly unlikely to ever be encountered on real
> > hardware, and this works with any line size >= 32)
>
> This should do.
>
> > -0:
> > +     adr     x4, 1f
> > +     dc      civac, x4
>
> s/civac/cvac/ ?
>

Ah yes, I changed that last minute because of
ARM64_WORKAROUND_CLEAN_CACHE - I'll add a note.

> Otherwise,
>
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Thanks



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux