On 07/10/2022 16:32, Kees Cook wrote: > [...] > Given OVMF showing this as a max, it doesn't seem right to also make > this a minimum? Perhaps choose a different minimum to be enforced. Hi Kees! Through my tests, I've noticed low values tend to cause issues (didn't go further in the investigation), IIRC even 512 caused problems on "deflate" (worked in the others). I'll try again 512 to see how it goes, but I'm not so sure what would be the use of such low values, it does truncate a lot and "pollute" the pstore fs with many small files. But I can go with any value you/Ard think is appropriate (given it works with all compression algorithms heh) - currently the minimum of 1024 is enforced in the patch. > > Also, can you update the commit log with Ard's archeology on > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize ? > Sure, of course! Cheers, Guilherme
