On Wed, Aug 17, 2022 at 09:09:41PM +0000, Kani, Toshi wrote:
> Since then, the change below enabled ghes_edac on Arm without this
> known-good platforms check.
>
> commit eaa3a1d46 ("EDAC, ghes: Make platform-based whitelisting x86-only")
Bah, I had forgotten about that one...
In any case, edac_mc_add_mc* is too late in the init path - that check
should happen as the very first thing in the driver init function.
And looking at the ARM64 EDAC drivers, they're only a couple: thunderx,
xgene, bluefield, dmc-520... And I'd still prefer if their maintainers
explicitly ACK such a change to call ghes_get_devices() (for a lack of a
better idea) and not enable ghes_edac on them blindly.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
