Hi Boris > -----Original Message----- > From: Borislav Petkov <bp@xxxxxxxxx> > Sent: Friday, August 12, 2022 10:46 PM > To: Justin He <Justin.He@xxxxxxx> > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; James > Morse <James.Morse@xxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; Mauro > Carvalho Chehab <mchehab@xxxxxxxxxx>; Robert Richter <rric@xxxxxxxxxx>; > Robert Moore <robert.moore@xxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; > Rafael J . Wysocki <rafael@xxxxxxxxxx>; Shuai Xue > <xueshuai@xxxxxxxxxxxxxxxxx>; Jarkko Sakkinen <jarkko@xxxxxxxxxx>; > linux-efi@xxxxxxxxxxxxxxx; nd <nd@xxxxxxx>; toshi.kani@xxxxxxx > Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use > > On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote: > > Before modularizing the ghes_edac codes, we need to export several > > efi/cper > > Who's we? > > Please use passive voice in your commit message: no "we" or "I", etc, and > describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Also, see section "Changelog" in > Documentation/process/maintainer-tip.rst > > Bottom line is: personal pronouns are ambiguous in text, especially with so > many parties/companies/etc developing the kernel so let's avoid them please. Okay，I will fix the commit description in next version. -- Cheers, Justin (Jia He)
