On 5/20/22 17:19, Huacai Chen wrote: > Hi, Javier, [snip] >> Conversely, if the sysfb_init() is executed first then the platform device >> will be registered and latter when the driver's init register the driver >> this will match the already registered device. > Yes, you are right, my consideration is too complex. The only real > problem is a harmless error "efifb: a framebuffer is already > registered" when both efifb and the native display driver are > built-in. > But this shouldn't be a problem if you drop your register_gop_device() that registers an "efi-framebuffer", since sysfb would either register a platform device "simple-framebufer" or "efi-framebuffer", but never both. Those are mutually exclusive. I think what's happening now is that sysfb is registering a "simple-framebuffer" but your register_gop_device() function is also registering an "efi-framebuffer". -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
