Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value

To: Andreas Schwab <schwab@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
From: Heinrich Schuchardt <xypron.glpk@xxxxxx>
Date: Mon, 14 Feb 2022 11:27:53 +0100
Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Atish Patra <atishp@xxxxxxxxxxxxxx>, linux-efi@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Anup Patel <apatel@xxxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>
In-reply-to: <87tud1vjn4.fsf@igel.home>
References: <20220128045004.4843-1-sunilvl@ventanamicro.com> <877d9xx14f.fsf@igel.home> <9cd9f149-d2ea-eb55-b774-8d817b9b6cc9@gmx.de> <87tud1vjn4.fsf@igel.home>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 2/14/22 11:15, Andreas Schwab wrote:

On Feb 14 2022, Heinrich Schuchardt wrote:

set_boot_hartid() implies that the caller can change the boot hart ID.
As this is not a case this name obviously would be a misnomer.


initialize_boot_hartid would fit better.


Another misnomer.

Follow-Ups:
- Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
  - From: Andreas Schwab

References:
- [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
  - From: Sunil V L
- Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
  - From: Andreas Schwab
- Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
  - From: Heinrich Schuchardt
- Re: [PATCH] riscv/efi_stub: Fix get_boot_hartid_from_fdt() return value
  - From: Andreas Schwab