Hi, I am this Chao Fan, and <fanc.fnst@xxxxxxxxxxxxxx> won't be used again. Please add me with fanchao.njupt@xxxxxxxxx Many thanks. Thanks, Chao Fan Michael Roth <michael.roth@xxxxxxx> 于2021年12月14日周二 11:46写道： > > On Fri, Dec 10, 2021 at 10:54:35AM -0800, Dave Hansen wrote: > > On 12/10/21 7:43 AM, Brijesh Singh wrote: > > > +/* > > > + * Helpers for early access to EFI configuration table > > > + * > > > + * Copyright (C) 2021 Advanced Micro Devices, Inc. > > > + * > > > + * Author: Michael Roth <michael.roth@xxxxxxx> > > > + */ > > > > It doesn't seem quite right to slap this copyright on a file that's full > > of content that came from other files. It would be one thing if > > arch/x86/boot/compressed/acpi.c had this banner in it already. Also, a > > Yah, acpi.c didn't have any copyright banner so I used my 'default' > template for new files here to cover any additions, but that does give > a misleading impression. > > I'm not sure how this is normally addressed, but I'm planning on just > continuing the acpi.c tradition of *not* adding copyright notices for new > code, and simply document that the contents of the file are mostly movement > from acpi.c > > > arch/x86/boot/compressed/acpi.c had this banner in it already. Also, a > > bunch of the lines in this file seem to come from: > > > > commit 33f0df8d843deb9ec24116dcd79a40ca0ea8e8a9 > > Author: Chao Fan <fanc.fnst@xxxxxxxxxxxxxx> > > Date: Wed Jan 23 19:08:46 2019 +0800 > > AFAICT the full author list for the changes in question are, in > alphabetical order: > > Chao Fan <fanc.fnst@xxxxxxxxxxxxxx> > Junichi Nomura <j-nomura@xxxxxxxxxxxxx> > Borislav Petkov <bp@xxxxxxx> > > Chao, Junichi, Borislav, > > If you would like to be listed as an author in efi.c (which is mainly just a > movement of EFI config table parsing code from acpi.c into re-usable helper > functions in efi.c), please let me know and I'll add you. > > Otherwise, I'll plan on adopting the acpi.c precedent for this as well, which > is to not list individual authors, since it doesn't seem right to add Author > fields retroactively without their permission.
