On Sat, 2022-01-08 at 20:47 -0500, Mimi Zohar wrote: > On Sun, 2022-01-09 at 00:30 +0200, Jarkko Sakkinen wrote: > > Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> > > > > Mimi, have you tested these patches already? > > Sorry, not yet this version this of the patch set. Planning to test > shortly. I've only tested v9 1/8 - 6/8 patches on top of Takashi Iwai and Joey Lee's patches, which are queued to be upstreamed. 92ad19559ea9 integrity: Do not load MOK and MOKx when secure boot be disabled 54bf7fa3efd0 ima: Fix undefined arch_ima_get_secureboot() and co With secure boot enabled and IMA_KEYRINGS_PERMIT_SIGNED_BY_BUILTIN_OR_SECONDARY disabled, all of the MOK keys are loaded onto the .machine keyring. With secure boot disabled, none of the MOK keys are loaded onto either the .platform or .machine keyrings, irrespective of IMA_KEYRINGS_PERMIT_SIGNED_BY_BUILTIN_OR_SECONDARY. This patch set is working as expected, but the v9 2/8 & 5/8 patch descriptions haven't been updated, nor have the related comments been updated. Please note that the subsequent patch set will limit the MOK keys being loaded onto the .machine keyring to only the MOK CA keys. thanks, Mimi
