Hi Eric, On Mon, 2021-11-15 at 19:15 -0500, Eric Snowberg wrote: > make W=1 generates the following warning in keyring_handler.c > > security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes] > __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type) > ^~~~~~~~~~~~~~~~~~ > security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes] > __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type) > ^~~~~~~~~~~~~~~~~~~ > Add the missing prototypes by including keyring_handler.h. > > Signed-off-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx> These sorts of fixes, which aren't really dependent on the patch set, could be moved to the begining of the patch set. Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
