On Fri, Aug 27, 2021 at 01:27:14PM -0500, Brijesh Singh wrote: > Those definitions are present in <asm/xxx>. Somewhere I read said that > if possible a new drivers should avoid including the <asm/xxx>. Where? That is news to me. It is likely possible that I might've missed that rule but it doesn't look like there's a rule like that at the moment: $ git grep -E "include.*asm" drivers/ | wc -l 4475 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette