On Mon, 2 Aug 2021 at 13:26, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, 2021-07-26 at 16:51 +0200, Ard Biesheuvel wrote: > > Ben reported that distro GRUB may fail to boot in some circumstances, > > and tracked it down to an issue in the way distro GRUB allocates space > > for the image. Due to an oversight (addressed in patch #2), this > > condition is rarely triggered, but let's work around it in any case (#1) > > > > Remaining patches add further warnings for conditions that are unlikely > > to occur, but should not be ignored. > > > > Build tested only. > > > > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > > All 4 patches: > > Tested-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > > I checked that it catches all of the errors, including reverting my fix > for randomalloc.c and verifying that it caught (and successfully worked > around) the original boot crash. > Excellent. Thanks for tracking this down and getting it fixed properly.