From: Ard Biesheuvel > Sent: 24 November 2020 15:02 > On Tue, 24 Nov 2020 at 15:58, David Laight <David.Laight@xxxxxxxxxx> wrote: > > > > From: Ard Biesheuvel > > > Sent: 24 November 2020 14:24 > > > > > > On Tue, 24 Nov 2020 at 15:22, David Laight <David.Laight@xxxxxxxxxx> wrote: > > > > > > > > I've just updated to the head of Linus's tree (5.10-rc5) and got the following > > > > 'splat' during shutdown. > > > > > > > > Userspace is Ubuntu 20.04. > > > > > > > > rc4 rebooted fine. > > > > > > > > I'll try to bisect - but it isn't quick. > > > > > > > > > > Surely caused by > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/efivarfs?id=fe5186cf12e30 > > > facfe261e9be6c7904a170bd822 > > > > Yep, reboots fine with that kfree() commented out. > > > > Thanks for confirming. > > Does it also work when keeping the kfree() and setting > inode->i_private to NULL explicitly afterwards? No, that still panics. Setting i_private NULL (but without the kfree()) is ok. I'm seeing 42 calls with a non-NULL i_private. The final call has i_private NULL and isn't a duplicate. There must be another pointer into one of the structures. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
