On Thu, Nov 5, 2020 at 11:23 PM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Nov 05, 2020 at 03:32:05PM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 1:43 AM Greg Kroah-Hartman > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > On Wed, Nov 04, 2020 at 03:23:54PM -0800, Saravana Kannan wrote: > > > > Add helper functions __fw_devlink_link_to_consumers() and > > > > __fw_devlink_link_to_suppliers() that convert fwnode links to device > > > > links. > > > > > > > > __fw_devlink_link_to_consumers() is for creating: > > > > - Device links between a newly added device and all its consumer devices > > > > that have been added to driver core. > > > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > > > the parent devices of all its consumers that have not been added to > > > > driver core yet. > > > > > > > > __fw_devlink_link_to_suppliers() is for creating: > > > > - Device links between a newly added device and all its supplier devices > > > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > > > all the supplier devices of its child device nodes. > > > > > > > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > > > > > Did you just add build warnings with these static functions that no one > > > calls? > > > > The next patch in this series uses it. I'm just splitting it up into a > > separate patch so that it's digestible and I can provide more details > > in the commit text. > > But you can not add build warnings, you know this :) I know I can't break the build because that'll screw git bisect. But I thought warning that's fixed later in the series might be okay if it helps readability. I know now :) > > > Couple of options: > > 1. Drop the static in this patch and add it back when it's used in patch 18/18. > > 2. Drop the commit text and squash this with 18/18 if you think the > > function documentation is clear enough and it won't make patch 18/18 > > too hard to review. > > It is hard to review new functions when you do not see them being used, > otherwise you have to flip back and forth between patches, which is > difficult. > > Add the functions, and use them, in the same patch. Otherwise we have > no idea _HOW_ you are using them, or even if you end up using them at > all. Sounds good. I'll squash them. -Saravana
