On Wed, Nov 04, 2020 at 03:23:53PM -0800, Saravana Kannan wrote: > The semantics of add_links() has changed from creating device link > between devices to creating fwnode links between fwnodes. So, update the > implementation of add_links() to match the new semantics. > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > --- > drivers/firmware/efi/efi-init.c | 23 ++--------------------- > 1 file changed, 2 insertions(+), 21 deletions(-) > > diff --git a/drivers/firmware/efi/efi-init.c b/drivers/firmware/efi/efi-init.c > index b148f1459fb3..c0c3d4c3837a 100644 > --- a/drivers/firmware/efi/efi-init.c > +++ b/drivers/firmware/efi/efi-init.c > @@ -316,11 +316,10 @@ static struct device_node *find_pci_overlap_node(void) > * resource reservation conflict on the memory window that the efifb > * framebuffer steals from the PCIe host bridge. > */ > -static int efifb_add_links(const struct fwnode_handle *fwnode, > +static int efifb_add_links(struct fwnode_handle *fwnode, > struct device *dev) So you are fixing the build warning you added a few patches ago here? Please fix up the function signatures when you made that change, not here later on. thanks, greg k-h
