On Wed, Oct 21, 2020 at 12:07 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 20:58, Joe Perches <joe@xxxxxxxxxxx> wrote: > > > Like the __section macro, the __alias macro uses > > > macro # stringification to create quotes around > > > the section name used in the __attribute__. > > > > > > Remove the stringification and add quotes or a > > > stringification to the uses instead. > > > > > > > Why? > > Using quotes in __section caused/causes differences > between clang and gcc. > > https://lkml.org/lkml/2020/9/29/2187 > > Using common styles for details like this is good. Luckily, there's no difference/issue here with alias as there exist with section: https://godbolt.org/z/eWxc7P So it's just a stylistic cleanup, not a bugfix. Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> $ grep -rn __attribute__ | grep alias didn't turn up any other cases that look like they don't use strings. -- Thanks, ~Nick Desaulniers
