Re: [PATCH] efi: mokvar-table: fix some issues in new code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 29 Sep 2020 at 18:58, Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Thu, Sep 24, 2020 at 06:05:46PM +0200, Ard Biesheuvel wrote:
> > Fix a couple of issues in the new mokvar-table handling code, as
> > pointed out by Arvind and Boris:
> > - don't bother checking the end of the physical region against the start
> >   address of the mokvar table,
> > - ensure that we enter the loop with err = -EINVAL,
> > - replace size_t with unsigned long to appease pedantic type equality
> >   checks.
> >
> > Cc: Lenny Szubowicz <lszubowi@xxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Arvind Sankar <nivedita@xxxxxxxxxxxx>
> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> > ---
> >  drivers/firmware/efi/mokvar-table.c | 25 +++++++++++--------------
> >  1 file changed, 11 insertions(+), 14 deletions(-)
>
> i386 allmodconfig looks good.
>
> Tested-by: Borislav Petkov <bp@xxxxxxx>
>

Thanks Boris. I'll have a PR out shortly.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux