On Tue, 15 Sep 2020 at 20:07, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: > > On Tue, 15 Sep 2020 at 19:33, Borislav Petkov <bp@xxxxxxxxx> wrote: > > > > On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote: > > > Memory errors could be printed with incorrect row values since the DIMM > > > size has outgrown the 16 bit row field in the CPER structure. UEFI > > > Specification Version 2.8 has increased the size of row by allowing it to > > > use the first 2 bits from a previously reserved space within the structure. > > > > > > When needed, add the extension bits to the row value printed. > > > > > > Based on UEFI 2.8 Table 299. Memory Error Record > > > > > > Reviewed-by: Kyle Meyer <kyle.meyer@xxxxxxx> > > > Reviewed-by: Steve Wahl <steve.wahl@xxxxxxx> > > > Tested-by: Russ Anderson <russ.anderson@xxxxxxx> > > > Signed-off-by: Alex Kluver <alex.kluver@xxxxxxx> > > > --- > > > > > > v1 -> v2: > > > * Add static inline cper_get_mem_extension() to make it > > > more readable, as suggested by Borislav Petkov. > > > > > > * Add second patch for bank field, bank group, and chip id. > > > > > > --- > > > drivers/edac/ghes_edac.c | 8 ++++++-- > > > drivers/firmware/efi/cper.c | 9 +++++++-- > > > include/linux/cper.h | 16 ++++++++++++++-- > > > 3 files changed, 27 insertions(+), 6 deletions(-) > > > > For the EDAC bits: > > > > Acked-by: Borislav Petkov <bp@xxxxxxx> > > > > Also, I could take both through the EDAC tree, if people prefer. > > > > I'll take this via the EFI tree - I was just preparing the branch for > a PR anyways. Alex - these patches do not apply cleanly. Could you please respin them on top of the next branch in https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git? Boris - do you anticipate any conflicts? If so, please take these via the EDAC tree - the CPER code is mostly self contained so I don't expect any conflicts with the EFI tree in that case.
