On Tue, Jul 28, 2020 at 09:56:40PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 28, 2020 at 12:44:50PM -0700, Kees Cook wrote: > > On Mon, Jul 27, 2020 at 09:23:34AM -0400, Mimi Zohar wrote: > > > On Fri, 2020-07-24 at 14:36 -0700, Kees Cook wrote: > > > > From: Scott Branden <scott.branden@xxxxxxxxxxxx> > > > > > > > > When the kernel_read_file LSM hook is called with contents=false, IMA > > > > can appraise the file directly, without requiring a filled buffer. When > > > > such a buffer is available, though, IMA can continue to use it instead > > > > of forcing a double read here. > > > > > > > > Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx> > > > > Link: https://lore.kernel.org/lkml/20200706232309.12010-10-scott.branden@xxxxxxxxxxxx/ > > > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> > > > > > > After adjusting the comment below. > > > > > > Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx> > > > > Sure! > > > > Greg, shall I send a v4 with added Reviews and the comment change or is > > that minor enough that you're able to do it? > > v4 is needed, as this series is a mess of reviewes and you will have to > redo at least one patch and drop some others, right? Well, I wasn't sure what your desire was, given the weirdness of taking some and reverting others. I will do a v4 based on driver-core-next. Thanks! -- Kees Cook
