Re: [PATCH v4 3/6] partitions: Introduce NVIDIA Tegra Partition Table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



15.05.2020 04:58, Randy Dunlap пишет:
> On 5/14/20 6:41 PM, Dmitry Osipenko wrote:
>> diff --git a/block/partitions/Kconfig b/block/partitions/Kconfig
>> index 702689a628f0..2c1408cba1a6 100644
>> --- a/block/partitions/Kconfig
>> +++ b/block/partitions/Kconfig
>> @@ -268,3 +268,11 @@ config CMDLINE_PARTITION
>>  	help
>>  	  Say Y here if you want to read the partition table from bootargs.
>>  	  The format for the command line is just like mtdparts.
>> +
>> +config TEGRA_PARTITION
>> +	bool "NVIDIA Tegra Partition support" if PARTITION_ADVANCED
>> +	default y if ARCH_TEGRA
>> +	depends on (ARCH_TEGRA && MMC_BLOCK) || COMPILE_TEST
> 
> That looks odd. Such depends are more often like:
> 	depends on MMC_BLOCK && (ARCH_TEGRA || COMPILE_TEST)
> 
> but that's just my experience. If this works when ARCH_TEGRA and MMC_BLOCK
> are not set and COMPILE_TEST is set, that's fine.

Ah, right! It shouldn't work since mmc_bdev_to_card() will be undefined
if MMC_BLOCK=n. Good catch, thank you! :)



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux