On Thu, 30 Apr 2020 at 22:40, Arvind Sankar <nivedita@xxxxxxxxxxxx> wrote: > > On Thu, Apr 30, 2020 at 09:29:46PM +0200, Ard Biesheuvel wrote: > > On Thu, 30 Apr 2020 at 21:12, Joe Perches <joe@xxxxxxxxxxx> wrote: > > > > > > Use a standard style for these output logging messages. > > > > > > Miscellanea: > > > > > > o Use more common macro #defines with fmt, ##__VA_ARGS__ > > > 0 Remove trailing messages periods and odd ' uses > > > o Remove embedded function names and use %s, __func__ > > > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > > --- > > > > > > Perhaps these trivialities on top of this series? > > > > > > > The EFI printing routines don't actually support format strings. > > > > The x86 real-mode bootup code actually has a printf.o that clocks in at > under 2k. We could add it in, and it would also be nice to move it into > lib or something, since at least alpha and powerpc implement something > very similar for boot-time messages. Not being able to use format strings is really quite annoying, and I did look into reusing the ordinary one (which is hairy), not realizing that there is already a cut down version available. So yes, that does sound like a great idea!
