On Thu, 2020-04-30 at 21:29 +0200, Ard Biesheuvel wrote: > On Thu, 30 Apr 2020 at 21:12, Joe Perches <joe@xxxxxxxxxxx> wrote: > > Use a standard style for these output logging messages. > > > > Miscellanea: > > > > o Use more common macro #defines with fmt, ##__VA_ARGS__ > > 0 Remove trailing messages periods and odd ' uses > > o Remove embedded function names and use %s, __func__ > > > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > > --- > > > > Perhaps these trivialities on top of this series? > > > > The EFI printing routines don't actually support format strings. Thanks. Then nevermind on that bit. > Removing trailing periods is not really necessary IMO, but i'll take a > patch that fixes those weird quotes. <shrug> Your choice. There are 60+ uses of efi_err, 12 with a trailing period. cheers, Joe
